Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrap errors #35

Merged
merged 2 commits into from
Dec 13, 2024
Merged

rewrap errors #35

merged 2 commits into from
Dec 13, 2024

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Dec 11, 2024

Description

Convert grpc errors to anyhow::Error and back.
Probably naming for functions could be better, advises welcomed

Checklist

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Test procedure added to nixos/tests
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

run-vm-test admin passed

@avnik avnik requested review from mbssrc and slakkala December 11, 2024 13:41
@avnik avnik force-pushed the avnik/rewrap-errors branch from 496b28b to 70c317e Compare December 12, 2024 08:25
@mbssrc
Copy link
Collaborator

mbssrc commented Dec 12, 2024

How did you test this?

slakkala
slakkala approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@slakkala slakkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable; some stylistic comments added.

src/utils/tonic.rs Outdated Show resolved Hide resolved
src/utils/tonic.rs Outdated Show resolved Hide resolved
src/utils/tonic.rs Outdated Show resolved Hide resolved
src/utils/tonic.rs Show resolved Hide resolved
client/src/error.rs Outdated Show resolved Hide resolved
@avnik avnik force-pushed the avnik/rewrap-errors branch 2 times, most recently from 0e7c39b to 36cc1f7 Compare December 13, 2024 11:30
avnik added 2 commits December 13, 2024 14:01
@avnik
Rewrap and propagate GRPC errors
b45e3a6 
Signed-off-by: Alexander V. Nikolaev <[email protected]>
@avnik
Suppress warnings
6a7506c 
Signed-off-by: Alexander V. Nikolaev <[email protected]>
@avnik avnik force-pushed the avnik/rewrap-errors branch from 36cc1f7 to 6a7506c Compare December 13, 2024 12:01
slakkala
slakkala approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@slakkala slakkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbssrc mbssrc merged commit f98999a into tiiuae:main Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slakkala slakkala slakkala approved these changes

@mbssrc mbssrc Awaiting requested review from mbssrc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avnik @mbssrc @slakkala