Simplify terraform configuration #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
henrirosten
commented
Nov 7, 2023
henrirosten
commented
- Remove unnecessary complexities that we don't (yet) need from the terraform configuration, including unused files and variables.
- Store initial VM admin username and key in sops instead of hard-coding them.
- Remove the separate shell.nix for terraform, merge it with the main shell.nix. This simplifies the usage as the terraform configuration can now be done from the main shell.
Remove unnecessary complexities that we don't (yet) need from the terraform configuration, including unused files and variables. Store initial VM admin username and key in sops instead of hard-coding them. Signed-off-by: Henri Rosten <[email protected]>
Remove the separate shell.nix for terraform, merge it with the main shell.nix. This simplifies the usage as the terraform configuration can now be done from the main shell. Signed-off-by: Henri Rosten <[email protected]>
karim20230
approved these changes
Nov 7, 2023
cazfi
reviewed
Nov 7, 2023
| @@ -41,14 +44,14 @@ This project stores the terraform state in a remote storage in an azure storage | |||
|
|
|||
| When starting a new infrastructure you need to initialize the terraform state storage: | |||
| ```bash | |||
| $ cd azure-storage/ | |||
| $ cd azure-storage | |||
There was a problem hiding this comment.
Earlier change added "/" to the end of 'cd' command, this one drops it. Make those consistent.
| # Resource group | ||
| resource "azurerm_resource_group" "ghaf_infra_tf_dev" { | ||
| name = "ghaf-infra-tf-dev" | ||
| location = var.resource_group_location | ||
| location = "swedencentral" |
There was a problem hiding this comment.
Is it necessary to add this hardcoding now? Before long we need this configurable (for the uae deployment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.