-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify tasks.py usage #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce 'alias' names for combinations of hostname (IP) and target nixosConfigurations. - Add task `alias-list` to list all alias names currently configured. - Change the task.py so that all tasks take the 'alias' name as an argument, instead of separate hostname and configuration name. This makes it less likely to accidentally apply a configuration to a wrong host. - This also makes it possible to apply tasks to all alias names. As an example, `deploy` without arguments could deploy all specified alias configurations at once. Such changes to tasks will be implemented later in a separate PR. Signed-off-by: Henri Rosten <[email protected]>
cazfi
approved these changes
Nov 6, 2023
Just a thought for now, but shall we use something with PKCS#11 interface instead of SOPS already at this point? |
karim20230
approved these changes
Nov 6, 2023
@alextserepov : I would propose we have this discussion separately, it's not really related to this PR. |
henrirosten
added a commit
that referenced
this pull request
Nov 6, 2023
- Pin nixos-anywhere to prevent possible issues caused by upstream PR: nix-community/nixos-anywhere#243. Read more from the below nixpkgs issue: NixOS/nixpkgs#265014. - Fix the task.py usage instructions in README.md after #8. - Make `nix flake check` pre-push check less verbose. Signed-off-by: Henri Rosten <[email protected]>
henrirosten
added a commit
that referenced
this pull request
Nov 6, 2023
- Pin nixos-anywhere to prevent possible issues caused by upstream PR: nix-community/nixos-anywhere#243. Read more from the below nixpkgs issue: NixOS/nixpkgs#265014. - Fix the task.py usage instructions in README.md after #8. - Make `nix flake check` pre-push check less verbose. Signed-off-by: Henri Rosten <[email protected]>
fayadf
pushed a commit
to fayadf/ghaf-infra
that referenced
this pull request
Oct 2, 2024
- Pin nixos-anywhere to prevent possible issues caused by upstream PR: nix-community/nixos-anywhere#243. Read more from the below nixpkgs issue: NixOS/nixpkgs#265014. - Fix the task.py usage instructions in README.md after tiiuae#8. - Make `nix flake check` pre-push check less verbose. Signed-off-by: Henri Rosten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alias-list
to list all alias names currently configured.deploy
without arguments could deploy all specified alias configurations at once. Such changes to tasks will be implemented later in a separate PR.