Add new version of nightly build pipeline #24
Conversation
This version adds parallel stages to visualize target testing. Signed-off-by: Marko Kaapu <[email protected]>
| steps { | ||
| ws('workspace/ghaf-pipeline/ghaf') { | ||
| sh ''' | ||
| PROVENANCE_TIMESTAMP_BEGIN=$(<TS_BEGIN_${GHAF_TARGET}) |
There was a problem hiding this comment.
There seems to be quite some duplication in here, and things that we should not set in jenkins. Any change we could move most of this (at least all the timestamp setting business) into a script wrapping the provenance run?
There was a problem hiding this comment.
So far practise seems to have been to avoid scripting (to keep declarative)... Of course when we start trapping erros and settings statuses, we cant avoid that
There was a problem hiding this comment.
I'm not saying we should script more in groovy for it to emit more boilerplate, yes. Ideally, the groovy script is as dumb as possible, so it still stays easy to invoke the commands locally.
I assume we set PROVENANCE_{EXTERNAL,INTERNAL}_PARAMS to be picked up by sbomnix? Can this be documented?
And maybe emitting timestamp files during startup, and on completion could be made part of sbomnix itself?
There was a problem hiding this comment.
That's for the provenance script: https://github.com/tiiuae/sbomnix/blob/main/doc/provenance.md.
Ping @joinemm.
There was a problem hiding this comment.
The timestamps should be the start and finish times of the nix build, so generating them in the provenance script would be inaccurate.
This params generation could be in some wrapper, but only if the jenkins env variables are available for that script.
This version adds parallel stages to visualize target testing.