ghaf-hw-test: Wget retry loop #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henri Rosten <[email protected]>
henrirosten
force-pushed
the
wget-retry-loop
branch
from
b5f9d71 to
7ba94dc
Compare
karim20230
approved these changes
Sep 2, 2024
mkaapu
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wget in the test network occasionally fails due to a failure in name lookup, causing test failures such as:
This PR adds a hack to force re-try the image download a few times before aborting the HW test pipeline. Wget options, such as
--tries,--waitretry,--retry-connrefused, etc. do not help in case the failure is due to an issue in name resolution, which is considered a fatal error. Therefore, we need to manually add such retry loop.At the same time, we are working with the test network service provider to make the DNS work properly; when it does, this hack should be removed.