Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Lenovo t14 amd #908

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[wip] Lenovo t14 amd #908

wants to merge 2 commits into from
+296 −105

Conversation

Mic92
Copy link
Collaborator

@Mic92 Mic92 commented Nov 21, 2024

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

Mic92 added 2 commits November 21, 2024 12:21
@Mic92
add option to disable compression in image builder
2849485 
This allows to incrementally update installations on usb-sticks without
having to go through the process of creating slow images.
@Mic92
lenovo-t14-amd: add profile
2be94fa
@Mic92 Mic92 temporarily deployed to internal-build-workflow November 21, 2024 11:22 — with GitHub Actions Inactive
Mic92
Mic92 commented Nov 21, 2024
View reviewed changes
modules/reference/hardware/lenovo-t14-amd/definitions/gen-5.nix
# Host configuration
host = {
kernelConfig.kernelParams = [
"amd_iommu=on"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will also update the script to detect amd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mic92