Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: GIVC TLS #915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: GIVC TLS #915

wants to merge 1 commit into from
+445 −347

Conversation

mbssrc
Copy link
Collaborator

@mbssrc mbssrc commented Nov 25, 2024

Description of changes

  • change networking into two different definitions to prepare network removal from host
  • improve config.networking integration
  • add and populate givc tls module
  • add givc-cli wrapper module for easier use in UI
  • remove logging from x86 profile

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

@mbssrc mbssrc temporarily deployed to internal-build-workflow November 25, 2024 10:09 — with GitHub Actions Inactive
@mbssrc
WIP: GIVC TLS
c73765e 
    - change networking into two different definitions to prepare network
      removal from host
    - add and populate givc tls module
    - add givc-cli wrapper module for easier use in UI
    - remove logging from x86 profile

Signed-off-by: Manuel Bluhm <[email protected]>
@mbssrc mbssrc temporarily deployed to internal-build-workflow November 25, 2024 10:50 — with GitHub Actions Inactive
dmitry-erin
dmitry-erin reviewed Dec 10, 2024
View reviewed changes
modules/common/services/desktop.nix
@@ -40,17 +40,6 @@ in
profiles.graphics.compositor = "labwc";
graphics = {
launchers =
let
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They might be needed for ctrl-panel as well, at least ´--notls´ option

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can add a wrapper for ctrl-panel as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-erin dmitry-erin dmitry-erin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbssrc @dmitry-erin