Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flash scripts as build result #927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

remimimimimi
Copy link
Contributor

Description of changes

Flash script is changing every now and then and each Ghaf binary images must be flashed to bootable drive with correct version of the flash.sh, so provide flash scripts alongside with images.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  1. Verify that installer still works.
  2. Check that all laptop and nvidia-jetson-orin packages result directory contains image and flash script(s).

@remimimimimi remimimimimi temporarily deployed to internal-build-workflow December 10, 2024 11:52 — with GitHub Actions Inactive
@remimimimimi remimimimimi marked this pull request as ready for review December 11, 2024 09:33
@remimimimimi remimimimimi added the Needs Testing CI Team to pre-verify label Dec 11, 2024
@milva-unikie

This comment was marked as outdated.

@milva-unikie milva-unikie added the bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR label Dec 11, 2024
@remimimimimi remimimimimi force-pushed the flash.sh-as-build-result branch from 635139e to 8ff48a7 Compare December 11, 2024 12:32
@remimimimimi remimimimimi temporarily deployed to internal-build-workflow December 11, 2024 12:32 — with GitHub Actions Inactive
@remimimimimi remimimimimi force-pushed the flash.sh-as-build-result branch from 8ff48a7 to d5078bf Compare December 11, 2024 12:33
@remimimimimi remimimimimi temporarily deployed to internal-build-workflow December 11, 2024 12:33 — with GitHub Actions Inactive
@remimimimimi remimimimimi force-pushed the flash.sh-as-build-result branch from d5078bf to a3043d5 Compare December 11, 2024 12:37
@remimimimimi remimimimimi temporarily deployed to internal-build-workflow December 11, 2024 12:37 — with GitHub Actions Inactive
@ktusawrk
Copy link
Collaborator

Do not merge before Ghaf release 24.12 is out. It is too late to make changes to test automation before the release.

@johannarautanen
Copy link

johannarautanen commented Dec 11, 2024

check the Orin AGX and NX. commit: 635139e

Screenshot from 2024-12-11 14-44-18

  • Not able to flash from the nvidia-jetson-orin-nx-debug-flash-script

flash.sh needed to Orin like in X1

@johannarautanen johannarautanen added bug on Orin AGX Issues found on NVIDIA Jetson AGX Orin while checking this PR bug on Orin NX Issues found on NVIDIA Jetson NX Orin while checking this PR and removed Needs Testing CI Team to pre-verify labels Dec 11, 2024
@johannarautanen
Copy link

check the RISC-V.

Screenshot from 2024-12-12 06-33-45

Screenshot from 2024-12-12 06-36-35

@johannarautanen johannarautanen added the bug on RISC-V Issues found on RISC-V - Microchip Polarfire Icicle-kit board while checking this PR label Dec 12, 2024
@remimimimimi remimimimimi force-pushed the flash.sh-as-build-result branch from a3043d5 to 3d9d7b3 Compare December 17, 2024 09:26
@remimimimimi remimimimimi temporarily deployed to internal-build-workflow December 17, 2024 09:26 — with GitHub Actions Inactive
Signed-off-by: Valentin Kharin <[email protected]>
@remimimimimi remimimimimi force-pushed the flash.sh-as-build-result branch from 3d9d7b3 to eb33175 Compare December 18, 2024 12:38
@remimimimimi remimimimimi temporarily deployed to internal-build-workflow December 18, 2024 12:38 — with GitHub Actions Inactive
@remimimimimi remimimimimi added the Needs Testing CI Team to pre-verify label Dec 18, 2024
@milva-unikie milva-unikie removed bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR bug on RISC-V Issues found on RISC-V - Microchip Polarfire Icicle-kit board while checking this PR bug on Orin AGX Issues found on NVIDIA Jetson AGX Orin while checking this PR bug on Orin NX Issues found on NVIDIA Jetson NX Orin while checking this PR labels Dec 19, 2024
@milva-unikie
Copy link

This change will require changes to test-automation. Those will need to be prepared before this pr is merged. They are under work now.

Tested with lenovo-x1-carbon-gen11-debug and lenovo-x1-carbon-gen11-installer (new builds)

  • Flash script is provided with the image.
  • New folder structure for lenovo-x1-carbon-gen11-debug is
result/
├── flash-script
│   └── bin
│       └── flash-script
└── image
    └── disk1.raw.zst

and for lenovo-x1-carbon-gen11-installer

result/
├── flash-script
│   └── bin
│       └── flash-script
└── image
│   └── iso
│       └── ghaf-25.05.20241119.23e89b7-x86_64-linux.iso

@johannarautanen
Copy link

johannarautanen commented Dec 19, 2024

Tested crosscompile with Orin AGX and NX

Working:

  • able to build the AGX and NX builds (earlier there was issue with AGX building, but at the moment building works fine again)

  • folder structures are:
    /result/flash-script/bin/flash-script
    /result/image/sd-image/nixos-sd-image-25.05.20241119.23e89b7-aarch64-linux.img.zst

  • able to boot the Ghaf via memory card and launch the applications

@johannarautanen johannarautanen added Tested on Orin NX Cross This PR has been tested on NVIDIA Jetson NX Orin cross-compiled bug on Orin AGX Cross Issues found on NVIDIA Jetson AGX Orin cross-compiled while checking this PR labels Dec 19, 2024
@johannarautanen
Copy link

Tested native with Orin AGX and NX

Working:

  • able to build the AGX and NX builds
  • folder structures are:
    /result/flash-script/bin/flash-script
    /result/image/sd-image/nixos-sd-image-25.05.20241119.23e89b7-aarch64-linux.img.zst
  • able to boot the Ghaf via memory card and launch the applications

@johannarautanen johannarautanen added Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin labels Dec 19, 2024
@johannarautanen
Copy link

Tested the Risc-V:

Working:

  • able to build the Risc-v build
  • folder structures are:
    /result/flash-script/bin/flash-script
    /result/image/nixos.img
  • risc-v booted up

@johannarautanen johannarautanen added Tested on RISC-V This PR has been tested on RISC-V - Microchip Polarfire Icicle-kit board Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled and removed bug on Orin AGX Cross Issues found on NVIDIA Jetson AGX Orin cross-compiled while checking this PR labels Dec 19, 2024
@milva-unikie
Copy link

I will add the bug-label here until the test-automation has been fixed to support this pr. We don't really have an accurate label for this situation.

@milva-unikie milva-unikie added bug Something isn't working Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Dec 19, 2024
@milva-unikie
Copy link

Test-automation has been checked and it works with this pr. This can now be merged.

@milva-unikie milva-unikie removed the bug Something isn't working label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin Tested on Orin NX Cross This PR has been tested on NVIDIA Jetson NX Orin cross-compiled Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin Tested on RISC-V This PR has been tested on RISC-V - Microchip Polarfire Icicle-kit board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants