Remove build errors in bootloader #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/nuttx/tls.h:52:4: warning: #warning CONFIG_TLS_NELEM is not defined [-Wcpp]
52 | # warning CONFIG_TLS_NELEM is not defined
| ^~~~~~~
In file included from include/nuttx/sched.h:48,
from include/nuttx/arch.h:87,
from include/nuttx/userspace.h:35,
from include/nuttx/mm/mm.h:30,
from include/nuttx/kmalloc.h:34,
from sim_bringup.c:33:
include/nuttx/tls.h:52:4: warning: #warning CONFIG_TLS_NELEM is not defined [-Wcpp]
52 | # warning CONFIG_TLS_NELEM is not defined
| ^~~~~~~
Signed-off-by: chao an <[email protected]>
pussuw
approved these changes
May 16, 2024
…_ram and _esbi_ram The original names are confusing; the symbols' addresses point to the start and end of the sbi executable ram area. This may also reside in l2lim and not in ddr, depending on the configuration, and this is defined in the linker script. Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
remove_build_errors
branch
from
ea6a031 to
34af573
Compare
|
Now tested the change. I had forgotten the mpfs_opensbi_utils.S . Changed that as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This for updating the nuttx in the saluki_bootloader_v2.
The tls warning removal is a direct cherry-pick from upstream.
Renaming the linker symbols is just a clean up; these same symbols are _ssbi_zerodev and _esbi_zerodev in the nuttx version in the bootloader currently.
Change the name to something that doesn't indicate where the sbi executable ram area is, it is anyhow determined in the linker script.