Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mavlink logger speedup config #507

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Conversation

jnippula
Copy link

@jnippula jnippula commented Oct 3, 2023

Flight logging over Mavlink is improved with parallel logging feature.
more info in src/modules/logger/parallel_mavlink_logging.md file

Parallel logging is enabled by adding following defines:
CONFIG_MAVLINK_PARALLEL_LOGGING
CONFIG_LOGGER_PARALLEL_LOGGING

Copy link

@jlaitine jlaitine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic design looks good to me! Maintaining this change will be difficult when there are upstream changes. Let's decide later whether we want to re-structure and up-stream this, or whether we can actually stop using mavlink logging altogether at some point.

@jnippula jnippula force-pushed the mavlink-logger-speedup-config branch from ef137ba to 4ce7bd5 Compare October 9, 2023 06:11
@jnippula jnippula force-pushed the mavlink-logger-speedup-config branch from 4ce7bd5 to df180cd Compare October 9, 2023 06:19
@jnippula jnippula merged commit 4c22f26 into main Oct 9, 2023
20 of 21 checks passed
@jnippula jnippula deleted the mavlink-logger-speedup-config branch June 6, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants