-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New GZ SIM compatible SITL build and rover fixes #532
Conversation
…on and smooth path following
963324b
to
986c176
Compare
LGTM, can you also @jnippula have a look |
Looks good. |
Yeah, we only have dep on gz-transport12 and none of the ROS2. But this Dockerfile for building px4 sitl was taken from Miika work https://github.com/tiiuae/gazebo-sim-sandbox/blob/main/Dockerfile.px4 which we have based on for SITL dev up until now. I was thinking of changing the base image and simplify the dockerfile in similar manner to https://github.com/tiiuae/px4-firmware/blob/main/packaging/Dockerfile.sitl but that would require some other time to verify if every would work the same. I will merge this now and will work on a simplified dockerfile latter. |
The rover pos control fixes were tested with previous main on UGV2 and again in gz sim with the new rebase main (to verify the actuator control msg change to vehicle torque and thrust setpoint msg)
All other changes were tested in gz sim