Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GZ SIM compatible SITL build and rover fixes #532

Merged
merged 8 commits into from
Oct 30, 2023
Merged

Conversation

haitomatic
Copy link

@haitomatic haitomatic commented Oct 27, 2023

  • rover pos control: fix ugv stuttering issue, enable stationary rotation and smooth path following
  • Add new px4 sitl build files for building px4 sitl container that's compatible with cloud simulation (dronsole) and gz sim
  • Add new and modify some gz sim airframes and normal airframes
  • rover interface: support in flight manual speed scaling and mission max speed scaling

The rover pos control fixes were tested with previous main on UGV2 and again in gz sim with the new rebase main (to verify the actuator control msg change to vehicle torque and thrust setpoint msg)
All other changes were tested in gz sim

@jlaitine
Copy link

LGTM, can you also @jnippula have a look

@jnippula
Copy link

jnippula commented Oct 27, 2023

Looks good.
Only thing I was thinking, do we need ROS2 install there (does not really harm there, but anyway)? At least RPLidar traffic from gzsim should go through gz_transport, so ROS2 should not be needed for that. But do we have any ROS2 plugins still there?

@haitomatic
Copy link
Author

Yeah, we only have dep on gz-transport12 and none of the ROS2. But this Dockerfile for building px4 sitl was taken from Miika work https://github.com/tiiuae/gazebo-sim-sandbox/blob/main/Dockerfile.px4 which we have based on for SITL dev up until now. I was thinking of changing the base image and simplify the dockerfile in similar manner to https://github.com/tiiuae/px4-firmware/blob/main/packaging/Dockerfile.sitl but that would require some other time to verify if every would work the same. I will merge this now and will work on a simplified dockerfile latter.
anway, i think fog-ros-baseimage-builder is a good to use even if we dont rely on ros2.

@haitomatic haitomatic merged commit 6cb5cce into main Oct 30, 2023
22 checks passed
@haitomatic haitomatic deleted the rover_updates branch November 3, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants