Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more crypto interfaces #556

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Add more crypto interfaces #556

merged 4 commits into from
Nov 23, 2023

Conversation

jlaitine
Copy link

@jlaitine jlaitine commented Nov 13, 2023

This is the first PR for enabling more crypto interfaces.

Next steps are to enable aes256 and write implementation for decrypting for xchacha and aes (for pfsoc crypto only)

@jlaitine jlaitine force-pushed the add_more_crypto_interfaces branch 2 times, most recently from fbdb526 to 95bfdfc Compare November 16, 2023 08:11
@jlaitine jlaitine force-pushed the add_more_crypto_interfaces branch 5 times, most recently from 8e0dd84 to 8cc6e24 Compare November 23, 2023 10:10
@jlaitine
Copy link
Author

@kjyrinki-unikie This now implements fully the aes-gcm, please have a look if you can use these interfaces ?

This is needed if using authenticated encryption/decryption (e.g. AES-GCM)

Signed-off-by: Jukka Laitinen <[email protected]>
Add renew_nonce and and decrypt_data interfaces, and also ioctl's for memory
protected builds. Stub these functions in sw_crypto driver. the functions are
currently not used but a stub is needed in order to build properly.

Add implementation for signature_check in PX4Crypto class, there is already an
implementation in the backend, but the function is missing from the PX4Crypto
interface.

Signed-off-by: Jukka Laitinen <[email protected]>
Signed-off-by: Jukka Laitinen <[email protected]>
Signed-off-by: Jukka Laitinen <[email protected]>
@jlaitine jlaitine force-pushed the add_more_crypto_interfaces branch 2 times, most recently from da8ea69 to fa97520 Compare November 23, 2023 12:48
@jlaitine
Copy link
Author

jlaitine commented Nov 23, 2023

Fixed alignment issues w. MAC, removed min_blocksize of 16 bytes requirement. Changed test code to use 247 -byte input & output

@jlaitine jlaitine merged commit 897ab52 into main Nov 23, 2023
20 checks passed
@jlaitine jlaitine deleted the add_more_crypto_interfaces branch December 1, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant