Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pfsoc crypto submodules #564

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Update pfsoc crypto submodules #564

merged 1 commit into from
Nov 27, 2023

Conversation

jlaitine
Copy link

This PR includes the following updates (in submodules):

  • Remove the 32-bit alignment requirement from RSA2048-OAEP arguments. There is anyhow temporary buffers used for the OAEP padding for SW, just use the same buffer also for athena calculations
  • Place all RSA temporary buffers into L2LIM memory to not expose them outside the SOC (DDR bus)
  • Correct the RSA calculation endianess in mpfs_crypto, prevously there was endianess swapping needed before and after the expmod

Copy link

@eenurkka eenurkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
a nitpick for later: (second row of needs a few spaces)

static void mpfs_crypto_mem32ld_le(uint32_t *dst, const void *src,
uint32_t words)

@jlaitine jlaitine force-pushed the rsa_calculation_fixes branch from e83745d to e932ece Compare November 24, 2023 12:18
Signed-off-by: Jukka Laitinen <[email protected]>
@jlaitine jlaitine force-pushed the rsa_calculation_fixes branch from e932ece to 01185ac Compare November 24, 2023 12:22
@jlaitine
Copy link
Author

LGTM, a nitpick for later: (second row of needs a few spaces)

static void mpfs_crypto_mem32ld_le(uint32_t *dst, const void *src, uint32_t words)

Thanks, fixed that still :)

@jlaitine
Copy link
Author

I already tested on saluki-v2, but after some cleanups I'll still do one more testing round on moday before merging.

@jlaitine
Copy link
Author

Done testing, seems to be working fine

@jlaitine jlaitine merged commit 7c0c1af into main Nov 27, 2023
19 of 20 checks passed
@jlaitine jlaitine deleted the rsa_calculation_fixes branch November 27, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants