Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the new sensor board for Saluki-FMU2 #736

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Enable the new sensor board for Saluki-FMU2 #736

merged 4 commits into from
Aug 14, 2024

Conversation

jlaitine
Copy link

@jlaitine jlaitine commented Aug 9, 2024

Enable the new sensor board for Saluki-FMU2

@jlaitine jlaitine force-pushed the update_sensors branch 6 times, most recently from bc30660 to 279711a Compare August 13, 2024 11:48
@jlaitine jlaitine changed the title Update ssrc submodules for a new sensor board Enable the new sensor board for Saluki-FMU2 Aug 13, 2024
@jlaitine jlaitine requested a review from jpaali August 13, 2024 11:50
@jlaitine
Copy link
Author

The new sensor board components have been tested on FMU2 + new sensor board. The fixes for the IMU driver are in upstream review, will wait for response from there before merging

@jlaitine jlaitine requested a review from kordets August 13, 2024 11:51
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing icm42688p & icm20649 with icm40609d may cause problems. We have (a lot of) devices with old sensor board. How to handle those? We need detect these somehow.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jaakko Isohella said that the new sensor board is the only one supported by FMU2. So we just drop the support for the old "rigid flex" board.

If DRDY signal is used, the interrupt status needs to be cleared at FIFO reset
in order to make DRDY go back inactive. Otherwise there won't be a falling edge
interrupt at the next sample.

Signed-off-by: Jukka Laitinen <[email protected]>
Disable I2C to make sure that the sensor doesn't switch to that by accident

Signed-off-by: Jukka Laitinen <[email protected]>
As the sensor can directly report the amount of samples in the fifo, use it to simplify the logic.

Also combine the fifo empty/fifo overflow checks for interrupt and polling modes.

Signed-off-by: Jukka Laitinen <[email protected]>
@jlaitine
Copy link
Author

Rotated the BMM350 to the correct orientation in saluki-pi submodule. It has moved to underneath the sensor board.

@jlaitine jlaitine merged commit 26fd002 into main Aug 14, 2024
28 checks passed
@jlaitine jlaitine deleted the update_sensors branch August 14, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants