Skip to content

Commit

Permalink
Remove unnecessary cleanup method in tests
Browse files Browse the repository at this point in the history
Removing the reference to the CssToInlineStyles instance after each test
is unnecessary as the TestCase itself will be collected once not
referenced anymore (and there is no circular reference preventing the
refcount to collect them).
Removing this method avoids getting static analysis reports about
assigning `null` in a non-nullable property.
  • Loading branch information
stof committed Dec 21, 2024
1 parent 0c2befd commit 0b47df1
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions tests/CssToInlineStylesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,6 @@ protected function prepare(): void
$this->cssToInlineStyles = new CssToInlineStyles();
}

/**
* @after
*/
protected function clear(): void
{
$this->cssToInlineStyles = null;
}

public function testNoXMLHeaderPresent(): void
{
$this->assertStringNotContainsString(
Expand Down

0 comments on commit 0b47df1

Please sign in to comment.