Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support config minimal wait duration #10

Merged
merged 3 commits into from
Sep 26, 2024
Merged

support config minimal wait duration #10

merged 3 commits into from
Sep 26, 2024

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Sep 25, 2024

No description provided.

kennytm
kennytm reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding some tests into mod tests_with_manual_clock to document the behavior of the new config.

src/limiter.rs Outdated Show resolved Hide resolved
@glorv
fix
0727ed1 
Signed-off-by: glorv <[email protected]>
@glorv
add a unit test
e9a2deb 
Signed-off-by: glorv <[email protected]>
@glorv
Copy link
Contributor Author

glorv commented Sep 25, 2024

consider adding some tests into mod tests_with_manual_clock to document the behavior of the new config.

Done.

@glorv
Copy link
Contributor Author

glorv commented Sep 26, 2024

friendly ping @kennytm PTAL

@glorv glorv mentioned this pull request Sep 26, 2024
Merged
9 tasks
@kennytm kennytm merged commit a113aef into tikv:master Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpadeA-Tang SpadeA-Tang SpadeA-Tang approved these changes

@nolouch nolouch nolouch approved these changes

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glorv @kennytm @nolouch @SpadeA-Tang