implement rollback for pipelined dml #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
you06
commented
Mar 18, 2024
| // TODO: implement cleanup. | ||
| // resolveFlushedLocks resolves all locks in the given range [start, end) with the given status. | ||
| // The resolve process is running in another goroutine so this function won't block. | ||
| func (c *twoPhaseCommitter) resolveFlushedLocks(bo *retry.Backoffer, start, end []byte, commit bool) { | ||
| const RESOLVE_CONCURRENCY = 8 | ||
| var resolved atomic.Uint64 |
There was a problem hiding this comment.
I'm not sure if we need to choose lower concurrency for rollback.
ekexium
reviewed
Mar 18, 2024
ekexium
reviewed
Mar 18, 2024
Signed-off-by: you06 <[email protected]> address comment Signed-off-by: you06 <[email protected]>
cfzjywxk
approved these changes
Mar 18, 2024
| @@ -334,6 +335,18 @@ func (c *twoPhaseCommitter) buildPipelinedResolveHandler(commit bool, resolved * | |||
| maxBackOff = CommitSecondaryMaxBackoff | |||
| } | |||
| regionCache := c.store.GetRegionCache() | |||
| // the handler function runs in a different goroutine, should copy the required values before it to avoid race. | |||
There was a problem hiding this comment.
As dicussed in above comments, this may not be a perfect solution, we still need to find a way to avoid race completely.
There was a problem hiding this comment.
Maybe set txn.committer to nil which disable further accessing to rollbacked committer.
ekexium
approved these changes
Mar 18, 2024
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref tikv/tikv#16291
Now the locks of rollback pipelined DML need to be cleaned up by GC. With this PR, the locks can be cleanup faster.
Flush phase
Rollback phase
SQL client