region_cache: filter out unresolved stores when GetTiFlashStores #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zyguan <[email protected]>
cfzjywxk
approved these changes
Apr 3, 2024
internal/locate/region_cache.go
Outdated
| @@ -2194,7 +2194,7 @@ func (c *RegionCache) PDClient() pd.Client { | |||
| // GetTiFlashStores returns the information of all tiflash nodes. | |||
There was a problem hiding this comment.
The comments should be updated too.
|
/cc @crazycs520 PTAL |
Signed-off-by: zyguan <[email protected]>
you06
approved these changes
Apr 4, 2024
ti-chi-bot
added
the
needs-cherry-pick-release-7.1
zyguan
added a commit
to zyguan/client-go
that referenced
this pull request
Apr 15, 2024
Signed-off-by: zyguan <[email protected]>
cfzjywxk
pushed a commit
that referenced
this pull request
Apr 17, 2024
Signed-off-by: zyguan <[email protected]>
ti-chi-bot
added
the
needs-cherry-pick-release-7.5
zyguan
added a commit
to zyguan/client-go
that referenced
this pull request
May 21, 2024
Signed-off-by: zyguan <[email protected]>
cfzjywxk
pushed a commit
that referenced
this pull request
May 21, 2024
Signed-off-by: zyguan <[email protected]>
ti-chi-bot
added
needs-cherry-pick-release-6.5
zyguan
added a commit
to zyguan/client-go
that referenced
this pull request
Jun 11, 2024
Signed-off-by: zyguan <[email protected]>
cfzjywxk
pushed a commit
that referenced
this pull request
Jun 11, 2024
Signed-off-by: zyguan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix pingcap/tidb#46602 .
GetTiFlashStoreswould return unresolved stores, which causes mpp probe keep checking tomebstone stores.RegionCacheexports some methods for listing stores, likeGetAllStores. There should/better be a contract that those methods do not return unresolved stores. Note thatGetTiFlashComputeStoresmay still returns unresolved stores, however, the entire store list will be reloaded once invalidate method get called, that is, it's users' responsibility to reload tiflash compute stores.