Allow setting session id of KVTxn #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ekexium <[email protected]>
cfzjywxk
reviewed
Apr 7, 2024
13 tasks
Signed-off-by: ekexium <[email protected]>
cfzjywxk
approved these changes
Apr 7, 2024
zyguan
approved these changes
Apr 8, 2024
MyonKeminta
approved these changes
Apr 8, 2024
| @@ -395,6 +395,22 @@ func (txn *KVTxn) SetTxnSource(txnSource uint64) { | |||
| txn.txnSource = txnSource | |||
| } | |||
|
|
|||
| // SetSessionID sets the session ID of the transaction. | |||
| // If the committer is not initialized yet, the function won't take effect. | |||
There was a problem hiding this comment.
For the concern of completeness of the API, do we consider put it to another field temporarily if the committer is not initialized yet, and use it lazily when initializing the committer?
There was a problem hiding this comment.
It's worth consideration. But I don't want to do it now as it's not needed
|
#908 Can this PR help? |
Signed-off-by: ekexium <[email protected]>
Yes. I tried to use ctx logger when possible. But it's not always feasible so SetSessionID is still needed for those cases. |
crazycs520
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explained by the comment.