p-dml: fail pipelined dml when max ttl exceeded (#1329) #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: you06 <[email protected]>
MyonKeminta
approved these changes
Apr 30, 2024
ekexium
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #1329 to tidb-8.1 branch
ref tikv/tikv#16291
Once the ttl manager is automatically closed after max ttl. And the PK may be rolled back after it, stop the ttl manager and fail the dml to avoid committing PK failure.
Without this PR, the worst case is p-dml cannot be aware of PK rollback, and keep flushing locks which block GC for a long time.