retry stale read as stale if leader is not accessible #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
dco-signoff: yes
mittalrishabh
force-pushed
the
rishabh_retry
branch
from
c43bc04 to
53cd393
Compare
ti-chi-bot
bot
added
dco-signoff: yes
cfzjywxk
reviewed
Jan 7, 2025
internal/locate/replica_selector.go
Outdated
| // don't overwhelm the leader if it is busy | ||
|
|
||
| maxAttempt := 1 | ||
| if !replica.isExhausted(maxAttempt, 0) || replica.hasFlag(deadlineErrUsingConfTimeoutFlag) || replica.hasFlag(serverIsBusyFlag) { |
There was a problem hiding this comment.
The !replica.isExhausted(maxAttempt, 0) is a little bit confusing, is it intended to check the leader.attempts == 0 which means the leader is not attempted at all?
There was a problem hiding this comment.
yes, i modified the code.
ti-chi-bot
bot
added
dco-signoff: no
Signed-off-by: rishabh_mittal <[email protected]>
Signed-off-by: rishabh_mittal <[email protected]>
Signed-off-by: rishabh_mittal <[email protected]>
Signed-off-by: rishabh_mittal <[email protected]>
Signed-off-by: rishabh_mittal <[email protected]>
Signed-off-by: rishabh_mittal <[email protected]>
mittalrishabh
force-pushed
the
rishabh_retry
branch
from
b7c346d to
fca73d9
Compare
ti-chi-bot
bot
added
dco-signoff: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue number : tikv/tikv#17422
It is the extension of the original PR #1509. I have observed that in case of hot regions, leaders are inaccessible and stale reads are retried as follower_follower. I have added a change if leader is not reachable or epoch doesn't mach than retry stale read as stale instead of follower.