Delete txn scope code #1587
Open
Delete txn scope code #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ekexium <[email protected]>
ti-chi-bot
bot
added
do-not-merge/work-in-progress
ekexium
force-pushed
the
remove-txn-scope-code
branch
from
72d2742 to
cf6688e
Compare
Signed-off-by: ekexium <[email protected]>
ekexium
force-pushed
the
remove-txn-scope-code
branch
from
cf6688e to
13eacc3
Compare
ti-chi-bot
bot
added
size/XXL
Signed-off-by: ekexium <[email protected]>
ti-chi-bot
bot
added
size/XL
Signed-off-by: ekexium <[email protected]>
ekexium
force-pushed
the
remove-txn-scope-code
branch
from
ebcff5c to
53fe1c7
Compare
ti-chi-bot
bot
added
size/XXL
Signed-off-by: ekexium <[email protected]>
ekexium
force-pushed
the
remove-txn-scope-code
branch
from
53fe1c7 to
4ab4b5f
Compare
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
cfzjywxk
requested review from
JmPotato,
you06,
MyonKeminta,
cfzjywxk and
zyguan
|
@JmPotato PTAL |
JmPotato
reviewed
Mar 3, 2025
config/config.go
Outdated
| TxnScope string | ||
| EnableAsyncCommit bool | ||
| Enable1PC bool | ||
| // FIXME: rename |
There was a problem hiding this comment.
Can you provide more explanation about this comment?
Comment on lines
43
to
46
| // Option represents available options for the oracle.Oracle. | ||
| // TODO: remove this struct | ||
| type Option struct { | ||
| TxnScope string | ||
| } |
There was a problem hiding this comment.
Why not just remove it in this PR?
There was a problem hiding this comment.
To minimize the change.. It has hundreds of usages. I prefer keeping this PR (relatively) small
zyguan
reviewed
Mar 6, 2025
Signed-off-by: ekexium <[email protected]>
Signed-off-by: ekexium <[email protected]>
Yes, I think it's the last step. After we deprecated txn-scope related code, we can rename those left to names like |
zyguan
approved these changes
Mar 6, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of pingcap/tidb#58838
Some changes that I'm not sure about:
TestMinSafeTsFromMixed1andTestMinSafeTsFromMixed2updateGlobalTxnScopeTSFromPD