Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update pd client #1605

Merged
merged 1 commit into from
Mar 11, 2025
Merged

*: update pd client #1605

merged 1 commit into from
Mar 11, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Mar 6, 2025

No description provided.

@rleungx
update pd client
93d6988 
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2025
@rleungx
Copy link
Member Author

rleungx commented Mar 6, 2025

/cc @lhy1024 @MyonKeminta @okJiang

@ti-chi-bot ti-chi-bot bot requested a review from MyonKeminta March 6, 2025 10:19
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 6, 2025

@rleungx: GitHub didn't allow me to request PR reviews from the following users: okJiang.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @lhy1024 @MyonKeminta @okJiang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot requested a review from lhy1024 March 6, 2025 10:19
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2025
@rleungx
Copy link
Member Author

rleungx commented Mar 6, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2025
@rleungx rleungx mentioned this pull request Mar 6, 2025
Merged
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 7, 2025
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2025
@rleungx
Copy link
Member Author

rleungx commented Mar 10, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 11, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 11, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-07 02:46:17.0090404 +0000 UTC m=+582490.137960139: ☑️ agreed by lhy1024.
  • 2025-03-11 02:13:20.294277328 +0000 UTC m=+235555.899806255: ☑️ agreed by zyguan.

@ti-chi-bot ti-chi-bot bot merged commit 34130b7 into tikv:master Mar 11, 2025
18 of 19 checks passed
@rleungx rleungx deleted the update-dep-2 branch March 11, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyguan zyguan zyguan approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rleungx @zyguan @lhy1024