-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add super batch for gRPC request and add more configures for client #363
Open
yongman
wants to merge
14
commits into
tikv:master
Choose a base branch
from
yongman:super-batch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+757
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yongman <[email protected]>
Signed-off-by: yongman <[email protected]>
Signed-off-by: yongman <[email protected]>
Signed-off-by: yongman <[email protected]>
Signed-off-by: yongman <[email protected]>
Signed-off-by: yongman <[email protected]>
Signed-off-by: yongman <[email protected]>
Signed-off-by: yongman <[email protected]>
Signed-off-by: yongman <[email protected]>
Signed-off-by: yongman <[email protected]>
Signed-off-by: yongman <[email protected]>
@ekexium @iosmanthus PTAL |
Signed-off-by: yongman <[email protected]>
Signed-off-by: yongman <[email protected]>
Signed-off-by: yongman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr, super batch mechanism was added, and this mechanism default to disabled, you can enable it by
and some other configures were added for batch size control, such as
I have do some benchmark in my development host with different
max_batch_size
(but keeps other configs same), and the result meet the expectation.The result shows the performance has obvious improvement.