Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc_rs for exporting internal APIs #50

Open
wants to merge 2 commits into
base: rs-release
Choose a base branch
from

Conversation

overvenus
Copy link
Member

As title.

By following command

  tools/buildgen/generate_projects.sh \
    --templates templates/CMakeLists.txt.template

Signed-off-by: Neil Shen <[email protected]>
@@ -534,6 +534,25 @@ GRPCXX_PUBLIC_HDRS = [
"include/grpcpp/impl/codegen/sync.h",
]

grpc_cc_library(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need a new library?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that code can be placed outside of src/core and let grpc and grpc_unsecure depends on it using its build system.
Anyway, what's your suggestion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not put the source in the source list just like CMakeLists.txt does?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMakeLists.txt is generated from BUILD, upstream may overwrite CMakeLists.txt if they add or remove a file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BusyJay PTAL, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused. Now is CMakeLists.txt auto-generated? Note we always need to modify CMakeLists.txt as the generated one from upstream doesn't always compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants