Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support prof.dump and prof.prefix #61

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

yuhao-su
Copy link

No description provided.

@yuhao-su yuhao-su marked this pull request as draft July 24, 2023 06:31
@yuhao-su yuhao-su force-pushed the yuhao/prof branch 2 times, most recently from a24507f to 52c834d Compare July 24, 2023 12:35
@yuhao-su
Copy link
Author

Hi @BusyJay , can you tell me how to pass the ci. I noticed the following test in ci. But the prof.dump and prof.prefix both requires profiling feature in jemalloc-sys and enable MALLOC_CONF=prof:true

cargo build --target "${TARGET}"
cargo test --target "${TARGET}"
cargo test --target "${TARGET}" --features profiling
cargo test --target "${TARGET}" --features debug
cargo test --target "${TARGET}" --features stats
cargo test --target "${TARGET}" --features 'debug profiling'

@BusyJay
Copy link
Member

BusyJay commented Jul 28, 2023

The test case can be marked as enabled only when profiling feature is enabled by #[cfg(feature = "profiling")].

yuhao-su added 6 commits July 31, 2023 16:46
Signed-off-by: Yuhao Su <[email protected]>
Signed-off-by: Yuhao Su <[email protected]>
Signed-off-by: Yuhao Su <[email protected]>
Signed-off-by: Yuhao Su <[email protected]>
Signed-off-by: Yuhao Su <[email protected]>
@yuhao-su yuhao-su marked this pull request as ready for review August 2, 2023 08:57
@yuhao-su
Copy link
Author

yuhao-su commented Aug 2, 2023

I notice the ci failed on x64 linux, but I tried the following test on a EC2 (Ubuntu 22.04) and it passed. Could you give me a little help on what causes the failure? @BusyJay

JEMALLOC_SYS_RUN_JEMALLOC_TESTS=1 _RJEM_MALLOC_CONF=prof:true cargo test --target x86_64-unknown-linux-gnu --features profiling

@@ -0,0 +1,3 @@
heap_v2/524288

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mistake?

Signed-off-by: TennyZhuang <[email protected]>
Signed-off-by: TennyZhuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants