Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[to #48] Create actions for CDC #86

Merged
merged 7 commits into from
Apr 19, 2022
Merged

[to #48] Create actions for CDC #86

merged 7 commits into from
Apr 19, 2022

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Apr 18, 2022

Signed-off-by: pingyu [email protected]

What problem does this PR solve?

Issue Number: to #48

Problem Description: TiKV CDC Development

What is changed and how does it work?

Code changes

  • Has exported function/method change
    No.
  • Has exported variable/fields change
    No.
  • Has interface methods change
    No.

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test

Side effects

No.

Signed-off-by: pingyu <[email protected]>
@pingyu pingyu requested review from zeminzhou and zz-jason April 18, 2022 07:46
pingyu added 4 commits April 18, 2022 17:39
Signed-off-by: pingyu <[email protected]>
Signed-off-by: pingyu <[email protected]>
Signed-off-by: pingyu <[email protected]>
Signed-off-by: pingyu <[email protected]>
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@3b82376). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 3d2d6c0 differs from pull request most recent head a06472f. Consider uploading reports for the commit a06472f to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##             main        #86   +/-   ##
=========================================
  Coverage        ?   53.3132%           
=========================================
  Files           ?        199           
  Lines           ?      19875           
  Branches        ?          0           
=========================================
  Hits            ?      10596           
  Misses          ?       8307           
  Partials        ?        972           
Flag Coverage Δ
cdc 53.3132% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pingyu
Copy link
Collaborator Author

pingyu commented Apr 18, 2022

PTAL~ @zz-jason @zeminzhou

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit aa54859 into tikv:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants