address the comment

Signed-off-by: Ryan Leung <[email protected]>
tikv · Aug 31, 2023 · 309aecc · 309aecc
1 parent 0bfbd0b
commit 309aecc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pkg/mcs/scheduling/server/cluster.go b/pkg/mcs/scheduling/server/cluster.go
@@ -22,6 +22,7 @@ import (
 
 // Cluster is used to manage all information for scheduling purpose.
 type Cluster struct {
+	ctx context.Context
 	*core.BasicCluster
 	persistConfig     *config.PersistConfig
 	ruleManager       *placement.RuleManager
@@ -45,6 +46,7 @@ func NewCluster(ctx context.Context, persistConfig *config.PersistConfig, storag
 	}
 	ruleManager := placement.NewRuleManager(storage, basicCluster, persistConfig)
 	c := &Cluster{
+		ctx:               ctx,
 		BasicCluster:      basicCluster,
 		ruleManager:       ruleManager,
 		labelerManager:    labelerManager,
@@ -146,7 +148,7 @@ func (c *Cluster) AllocID() (uint64, error) {
 		c.checkMembershipCh <- struct{}{}
 		return 0, errors.New("API server leader is not found")
 	}
-	resp, err := cli.AllocID(context.Background(), &pdpb.AllocIDRequest{Header: &pdpb.RequestHeader{ClusterId: c.clusterID}})
+	resp, err := cli.AllocID(c.ctx, &pdpb.AllocIDRequest{Header: &pdpb.RequestHeader{ClusterId: c.clusterID}})
 	if err != nil {
 		c.checkMembershipCh <- struct{}{}
 		return 0, err

diff --git a/pkg/mcs/server/server.go b/pkg/mcs/server/server.go
@@ -61,7 +61,7 @@ func (bs *BaseServer) Context() context.Context {
 	return bs.ctx
 }
 
-// GetDelegateClient returns grpc client connection talking to the forwarded host
+// GetDelegateClient returns grpc client connection talking to the forwarded host.
 func (bs *BaseServer) GetDelegateClient(ctx context.Context, tlsCfg *grpcutil.TLSConfig, forwardedHost string) (*grpc.ClientConn, error) {
 	client, ok := bs.clientConns.Load(forwardedHost)
 	if !ok {