Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: get region info via core cluster inside RegionStatistics (#6804) #6814

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6804

What problem does this PR solve?

Issue Number: Close #6560.

What is changed and how does it work?

Instead of maintaining its own region info cache, use the core cluster to
fetch the region info inside `RegionStatistics` to make sure consistency.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Run pd-ctl region check miss-peer:

[
  {
      "id": 22,
      "start_key": "7480000000000000FF5C00000000000000F8",
      "end_key": "748000FFFFFFFFFFFFF900000000000000F8",
      "epoch": {
        "conf_ver": 1,
        "version": 56
      },
      "peers": [
        {
          "id": 23,
          "store_id": 1,
          "role_name": "Voter"
        }
      ],
      "leader": {
        "id": 23,
        "store_id": 1,
        "role_name": "Voter"
      },
      "cpu_usage": 0,
      "written_bytes": 204,
      "read_bytes": 0,
      "written_keys": 4,
      "read_keys": 0,
      "approximate_size": 1,
      "approximate_keys": 0
  }
]

Run pd-ctl region 22:

{
  "id": 22,
  "start_key": "7480000000000000FF5C00000000000000F8",
  "end_key": "748000FFFFFFFFFFFFF900000000000000F8",
  "epoch": {
    "conf_ver": 1,
    "version": 56
  },
  "peers": [
    {
      "id": 23,
      "store_id": 1,
      "role_name": "Voter"
    }
  ],
  "leader": {
    "id": 23,
    "store_id": 1,
    "role_name": "Voter"
  },
  "cpu_usage": 0,
  "written_bytes": 204,
  "read_bytes": 0,
  "written_keys": 4,
  "read_keys": 0,
  "approximate_size": 1,
  "approximate_keys": 0
}

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jul 17, 2023
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick. labels Jul 17, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from disksing and rleungx July 17, 2023 06:37
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 17, 2023
@nolouch
Copy link
Contributor

nolouch commented Jul 19, 2023

no need for 5.x

@nolouch nolouch closed this Jul 19, 2023
@JmPotato JmPotato deleted the cherry-pick-6804-to-release-5.3 branch July 20, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants