-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global config: fix etcd client not found (#6866) #6943
global config: fix etcd client not found (#6866) #6943
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fix conlict
bb287a4
to
20b0b06
Compare
/hold |
Signed-off-by: husharp <[email protected]>
dacf8bf
to
b74fc07
Compare
Signed-off-by: husharp <[email protected]>
/test build |
@HuSharp: No presubmit jobs available for tikv/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/test |
@HuSharp: No presubmit jobs available for tikv/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/merge |
@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 7d52dcd
|
/merge |
@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-5.4 #6943 +/- ##
===============================================
- Coverage 74.83% 74.54% -0.30%
===============================================
Files 265 265
Lines 28012 28019 +7
===============================================
- Hits 20963 20886 -77
- Misses 5196 5267 +71
- Partials 1853 1866 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This is an automated cherry-pick of #6866
What problem does this PR solve?
Issue Number: Close #6860
What is changed and how does it work?
Check List
Tests
Release note