-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduling: watch the respective scheduler config and trim the prefix #6955
Conversation
Signed-off-by: JmPotato <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6955 +/- ##
==========================================
+ Coverage 74.26% 74.40% +0.14%
==========================================
Files 427 427
Lines 45270 45315 +45
==========================================
+ Hits 33618 33718 +100
+ Misses 8693 8640 -53
+ Partials 2959 2957 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: JmPotato <[email protected]>
Can the schedulers run normally now? |
Currently
So currently I'd like to keep this PR to only implement the synchronization logic, WDYT? |
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 2f49527
|
@JmPotato: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…tikv#6955) ref tikv#5839 - Make scheduling service watch the respective scheduler config. - Trim the key prefix inside the watcher. Signed-off-by: JmPotato <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: rishabh_mittal <[email protected]>
…tikv#6955) ref tikv#5839 - Make scheduling service watch the respective scheduler config. - Trim the key prefix inside the watcher. Signed-off-by: JmPotato <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: ref #5839.
What is changed and how does it work?
Check List
Tests
Release note