Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leadership: check leadership key before exit watch loop #6979

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Aug 23, 2023

What problem does this PR solve?

Issue Number: Close #6977

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 23, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx August 23, 2023 09:57
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 23, 2023
Signed-off-by: lhy1024 <[email protected]>
@rleungx
Copy link
Member

rleungx commented Aug 23, 2023

Why open a new PR?

@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 23, 2023

Why open a new PR?

To solve #6977, reduce unnecessary elections after stopping pd-leader-io-hang.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #6979 (7643816) into master (7dc9d17) will decrease coverage by 0.26%.
Report is 177 commits behind head on master.
The diff coverage is 83.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6979      +/-   ##
==========================================
- Coverage   74.51%   74.25%   -0.26%     
==========================================
  Files         427      433       +6     
  Lines       45149    45967     +818     
==========================================
+ Hits        33642    34135     +493     
- Misses       8552     8824     +272     
- Partials     2955     3008      +53     
Flag Coverage Δ
unittests 74.25% <83.01%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

leadership: unnecessary leadership election after pd-leader-io-hang
2 participants