Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: extract the common part as base server #7013

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 30, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

There is too many duplicated code in the different services. Maintaining one copy will help us reduce the probability of making mistakes.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 30, 2023
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #7013 (17c1a56) into master (7a4e1e2) will increase coverage by 0.08%.
Report is 1 commits behind head on master.
The diff coverage is 71.26%.

❗ Current head 17c1a56 differs from pull request most recent head 8a2cbac. Consider uploading reports for the commit 8a2cbac to get more accurate results

@@            Coverage Diff             @@
##           master    #7013      +/-   ##
==========================================
+ Coverage   74.20%   74.29%   +0.08%     
==========================================
  Files         433      434       +1     
  Lines       46101    46036      -65     
==========================================
- Hits        34209    34202       -7     
+ Misses       8872     8832      -40     
+ Partials     3020     3002      -18     
Flag Coverage Δ
unittests 74.29% <71.26%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

return bs.ctx
}

// GetDelegateClient returns grpc client connection talking to the forwarded host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// GetDelegateClient returns grpc client connection talking to the forwarded host
// GetDelegateClient returns grpc client connection talking to the forwarded host.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in another PR.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 31, 2023
@rleungx
Copy link
Member Author

rleungx commented Aug 31, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 50ea886

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 31, 2023
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 31, 2023
@rleungx
Copy link
Member Author

rleungx commented Aug 31, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 17c1a56

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 31, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 934c9df into tikv:master Aug 31, 2023
19 checks passed
@rleungx rleungx deleted the refactor-mcs-server branch August 31, 2023 07:42
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5839

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants