-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcs: extract the common part as base server #7013
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
237ce44
to
50ea886
Compare
Codecov Report
@@ Coverage Diff @@
## master #7013 +/- ##
==========================================
+ Coverage 74.20% 74.29% +0.08%
==========================================
Files 433 434 +1
Lines 46101 46036 -65
==========================================
- Hits 34209 34202 -7
+ Misses 8872 8832 -40
+ Partials 3020 3002 -18
Flags with carried forward coverage won't be shown. Click here to find out more. |
return bs.ctx | ||
} | ||
|
||
// GetDelegateClient returns grpc client connection talking to the forwarded host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// GetDelegateClient returns grpc client connection talking to the forwarded host | |
// GetDelegateClient returns grpc client connection talking to the forwarded host. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in another PR.
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 50ea886
|
Signed-off-by: Ryan Leung <[email protected]>
f112d15
to
17c1a56
Compare
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 17c1a56
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref tikv#5839 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Ref #5839.
What is changed and how does it work?
There is too many duplicated code in the different services. Maintaining one copy will help us reduce the probability of making mistakes.
Check List
Tests
Release note