-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix the static checks from the latest tools #7014
Conversation
Signed-off-by: JmPotato <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@@ -50,7 +50,7 @@ const ( | |||
// PDRedirectorHeader is used to mark which PD redirected this request. | |||
PDRedirectorHeader = "PD-Redirector" | |||
// PDAllowFollowerHandleHeader is used to mark whether this request is allowed to be handled by the follower PD. | |||
PDAllowFollowerHandleHeader = "PD-Allow-follower-handle" | |||
PDAllowFollowerHandleHeader = "PD-Allow-follower-handle" // #nosec G101 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused why we have to add this comment :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like a false positive error:
pkg/utils/apiutil/apiutil.go:53:2: G101: Potential hardcoded credentials (gosec)
PDAllowFollowerHandleHeader = "PD-Allow-follower-handle"
^
Codecov Report
@@ Coverage Diff @@
## master #7014 +/- ##
==========================================
- Coverage 74.33% 74.05% -0.28%
==========================================
Files 433 433
Lines 46097 46099 +2
==========================================
- Hits 34265 34138 -127
- Misses 8830 8945 +115
- Partials 3002 3016 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 15fad8e
|
What problem does this PR solve?
Issue Number: ref #4399.
What is changed and how does it work?
Check List
Tests
Release note