Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: remove cancel reason for successfully finishing operator #7019

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 31, 2023

What problem does this PR solve?

Issue Number: Close #4399

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Aug 31, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and lhy1024 August 31, 2023 06:27
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 31, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #7019 (5625b8e) into master (a7353bb) will decrease coverage by 0.08%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 5625b8e differs from pull request most recent head 3ace0cb. Consider uploading reports for the commit 3ace0cb to get more accurate results

@@            Coverage Diff             @@
##           master    #7019      +/-   ##
==========================================
- Coverage   74.22%   74.15%   -0.08%     
==========================================
  Files         433      433              
  Lines       46139    46099      -40     
==========================================
- Hits        34247    34185      -62     
- Misses       8876     8892      +16     
- Partials     3016     3022       +6     
Flag Coverage Δ
unittests 74.15% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 31, 2023
@nolouch
Copy link
Contributor

nolouch commented Aug 31, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 5625b8e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 31, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit bce3133 into tikv:master Aug 31, 2023
19 checks passed
@rleungx rleungx deleted the remove-cancel branch August 31, 2023 10:17
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
…ikv#7019)

close tikv#4399

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta issue
3 participants