Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs, tso: add more metrics on the TSO critical path #7040

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Sep 4, 2023

What problem does this PR solve?

Issue Number: ref #7011.

What is changed and how does it work?

Add more metrics on the TSO critical path to monitor some key duration costs.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added component/metrics Metrics. component/tso Timestamp Oracle. component/mcs Microservice. labels Sep 4, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 4, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2023
@JmPotato JmPotato mentioned this pull request Sep 4, 2023
3 tasks
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 4, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #7040 (064070e) into master (877f47b) will decrease coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is 95.34%.

@@            Coverage Diff             @@
##           master    #7040      +/-   ##
==========================================
- Coverage   74.46%   74.40%   -0.07%     
==========================================
  Files         435      435              
  Lines       46284    46310      +26     
==========================================
- Hits        34465    34455      -10     
- Misses       8808     8832      +24     
- Partials     3011     3023      +12     
Flag Coverage Δ
unittests 74.40% <95.34%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@JmPotato
Copy link
Member Author

JmPotato commented Sep 5, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 064070e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 5, 2023
@ti-chi-bot ti-chi-bot bot merged commit 7d50755 into tikv:master Sep 5, 2023
23 checks passed
@JmPotato JmPotato deleted the add_more_tso_metrics branch September 5, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mcs Microservice. component/metrics Metrics. component/tso Timestamp Oracle. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants