Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: enable store limit v2 in raftstore-v2 #7098

Merged
merged 6 commits into from
Sep 18, 2023
Merged

config: enable store limit v2 in raftstore-v2 #7098

merged 6 commits into from
Sep 18, 2023

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Sep 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #7099

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

tiup playground nightly --tiflash 0 --kv 4 --kv.config ./tikv.toml --pd.binpath ./bin/pd-server
image

Code changes

Side effects

Related changes

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Sep 14, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Merging #7098 (d98d053) into master (0888ef6) will increase coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 64.90%.

@@            Coverage Diff             @@
##           master    #7098      +/-   ##
==========================================
+ Coverage   74.33%   74.38%   +0.04%     
==========================================
  Files         437      438       +1     
  Lines       46855    46955     +100     
==========================================
+ Hits        34831    34927      +96     
- Misses       8947     8951       +4     
  Partials     3077     3077
Flag Coverage Δ
unittests 74.38% <64.90%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@bufferflies bufferflies changed the title confg: enable store limit v2 in raftstore-v2 config: enable store limit v2 in raftstore-v2 Sep 15, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 18, 2023
nolouch
nolouch reviewed Sep 18, 2023
View reviewed changes
server/cluster/cluster.go
@@ -436,7 +436,7 @@ func (c *RaftCluster) runStoreConfigSync() {
for {
synced, switchRaftV2Config = c.syncStoreConfig(stores)
if switchRaftV2Config {
if err := c.opt.Persist(c.GetStorage()); err != nil {
if err := c.opt.SwitchRaftV2(c.GetStorage()); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I manually switch to v1, will it switch to v2 back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In past，the store config will persist also, so it will not switch v1 again after tikv restarted.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2023
@nolouch
Copy link
Contributor

nolouch commented Sep 18, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 4d31eec

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit 559ea7f into tikv:master Sep 18, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@nolouch nolouch nolouch approved these changes

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable store-limit-v2 in partition raftstore v2
3 participants
@bufferflies @nolouch @disksing