Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs/resourcemanager: add metric for TiFlash RU consumption #7115

Merged
merged 8 commits into from
Sep 21, 2023
Merged

mcs/resourcemanager: add metric for TiFlash RU consumption #7115

merged 8 commits into from
Sep 21, 2023

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Sep 19, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #7116

What is changed and how does it work?

add metric for tiflash ru consumption

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)
    image

  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 19, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Sep 19, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Sep 19, 2023
@guo-shaoge
refine
1201929 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2023
@guo-shaoge
ci
f783bff 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2023
@guo-shaoge
ci
23805a2 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
ci
7d57bbc 
Signed-off-by: guo-shaoge <[email protected]>
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #7115 (a2cd62c) into master (a997316) will increase coverage by 0.06%.
The diff coverage is 68.75%.

❗ Current head a2cd62c differs from pull request most recent head 8622eea. Consider uploading reports for the commit 8622eea to get more accurate results

@@            Coverage Diff             @@
##           master    #7115      +/-   ##
==========================================
+ Coverage   74.32%   74.38%   +0.06%     
==========================================
  Files         440      440              
  Lines       47195    47157      -38     
==========================================
+ Hits        35076    35078       +2     
+ Misses       9024     8993      -31     
+ Partials     3095     3086       -9
Flag Coverage Δ
unittests 74.38% <68.75%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nolouch nolouch requested review from nolouch and HuSharp and removed request for disksing and rleungx September 20, 2023 03:39
@guo-shaoge
add tidb label type
6f9b3c9 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2023
nolouch
nolouch approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 20, 2023
HuSharp
HuSharp approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 21, 2023
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: a2cd62c

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

@guo-shaoge: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JmPotato JmPotato changed the title add metric for tiflash ru consumption mcs/resourcemanager: add metric for TiFlash RU consumption Sep 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit 62ff67a into tikv:master Sep 21, 2023
19 checks passed
CabinfeverB
CabinfeverB reviewed Sep 21, 2023
View reviewed changes
pkg/mcs/resourcemanager/server/metrics.go
@@ -26,6 +26,8 @@ const (
readTypeLabel = "read"
writeTypeLabel = "write"
backgroundTypeLabel = "background"
tiflashTypeLabel = "tiflash"
tidbTypeLabel = "tidb"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this label may be confusing to the users. /cc @HuSharp

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users may wonder how much RU TiKV consumes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to tp/ap #7135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@CabinfeverB CabinfeverB CabinfeverB left review comments

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add metric for tiflash ru consumption
5 participants
@guo-shaoge @JmPotato @nolouch @CabinfeverB @HuSharp