-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcs/resourcemanager: add metric for TiFlash RU consumption #7115
Conversation
Signed-off-by: guo-shaoge <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #7115 +/- ##
==========================================
+ Coverage 74.32% 74.38% +0.06%
==========================================
Files 440 440
Lines 47195 47157 -38
==========================================
+ Hits 35076 35078 +2
+ Misses 9024 8993 -31
+ Partials 3095 3086 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: guo-shaoge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: a2cd62c
|
@guo-shaoge: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@@ -26,6 +26,8 @@ const ( | |||
readTypeLabel = "read" | |||
writeTypeLabel = "write" | |||
backgroundTypeLabel = "background" | |||
tiflashTypeLabel = "tiflash" | |||
tidbTypeLabel = "tidb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this label may be confusing to the users. /cc @HuSharp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users may wonder how much RU TiKV consumes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to tp/ap #7135
What problem does this PR solve?
Issue Number: Close #7116
What is changed and how does it work?
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note