Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "cluster: handle region after report split (#6867)" #7134

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 22, 2023

This reverts commit a997316.

What problem does this PR solve?

Issue Number: Close #7133

What is changed and how does it work?

This PR reverts #6867 since it will block CI of other repo, after we fix the problem, we will review that commit again.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Sep 22, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Sep 22, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #7134 (1628bed) into master (e94b4e4) will decrease coverage by 0.13%.
The diff coverage is 76.19%.

❗ Current head 1628bed differs from pull request most recent head 4b15a35. Consider uploading reports for the commit 4b15a35 to get more accurate results

@@            Coverage Diff             @@
##           master    #7134      +/-   ##
==========================================
- Coverage   74.56%   74.44%   -0.13%     
==========================================
  Files         440      440              
  Lines       47262    47217      -45     
==========================================
- Hits        35243    35150      -93     
- Misses       8949     8981      +32     
- Partials     3070     3086      +16     
Flag Coverage Δ
unittests 74.44% <76.19%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2023
@wuhuizuo
Copy link
Contributor

/run-issue-triage

@rleungx
Copy link
Member Author

rleungx commented Sep 22, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 1628bed

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2023
@wuhuizuo
Copy link
Contributor

/run-check-issue-triage-complete

@rleungx
Copy link
Member Author

rleungx commented Sep 22, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 4b15a35

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit e6c8841 into tikv:master Sep 22, 2023
19 checks passed
@rleungx rleungx deleted the revert-6867 branch September 22, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pd panic during br restore data and run workload
4 participants