Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_control: dynamically change the controller config (#7042) #7495

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7042

What problem does this PR solve?

Issue Number: Close #7043

What is changed and how does it work?

resource_control: supports dynamically change the controller config 
- supports dynamically changing the controller config
- export the `maxWaitDuration` for the local bucket limiter.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot added affects-7.1 release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Dec 5, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

CabinfeverB and others added 6 commits December 6, 2023 15:37
ref tikv#6509

Signed-off-by: Cabinfever_B <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
…ikv#6624)

close tikv#6623

Signed-off-by: Cabinfever_B <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
close tikv#6808

Currently, there are no static checks for subdirectories

Signed-off-by: husharp <[email protected]>
…ikv#7042)

close tikv#7043

resource_control: supports dynamically change the controller config
- supports dynamically changing the controller config
- export the `maxWaitDuration` for the local bucket limiter.

Signed-off-by: nolouch <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

fix

Signed-off-by: nolouch <[email protected]>
close tikv#7095

Signed-off-by: husharp <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@nolouch nolouch force-pushed the cherry-pick-7042-to-release-7.1 branch from 5861e97 to 63f7bd2 Compare December 6, 2023 17:24
nolouch and others added 2 commits December 7, 2023 01:26
@nolouch nolouch force-pushed the cherry-pick-7042-to-release-7.1 branch from 6aee085 to b239ee5 Compare December 6, 2023 17:53
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 6, 2023
@nolouch nolouch force-pushed the cherry-pick-7042-to-release-7.1 branch from 272f23f to d196285 Compare December 7, 2023 04:10
Signed-off-by: nolouch <[email protected]>
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Comparison is base (0b048b1) 74.93% compared to head (06d80ef) 74.86%.

Files Patch % Lines
client/resource_group/controller/controller.go 60.58% 41 Missing and 13 partials ⚠️
pkg/mcs/resource_manager/server/manager.go 53.65% 12 Missing and 7 partials ⚠️
client/meta_storage_client.go 37.50% 7 Missing and 3 partials ⚠️
pkg/mcs/resource_manager/server/apis/v1/api.go 43.75% 6 Missing and 3 partials ⚠️
client/resource_group/controller/util.go 42.85% 6 Missing and 2 partials ⚠️
client/resource_manager_client.go 50.00% 3 Missing and 2 partials ⚠️
client/resource_group/controller/testutil.go 0.00% 1 Missing ⚠️
server/grpc_service.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #7495      +/-   ##
===============================================
- Coverage        74.93%   74.86%   -0.08%     
===============================================
  Files              409      410       +1     
  Lines            41366    41513     +147     
===============================================
+ Hits             30998    31077      +79     
- Misses            7658     7699      +41     
- Partials          2710     2737      +27     
Flag Coverage Δ
unittests 74.86% <59.46%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nolouch nolouch force-pushed the cherry-pick-7042-to-release-7.1 branch from d196285 to c8b9ee7 Compare December 7, 2023 05:15
@nolouch nolouch changed the title resource_control: supports dynamically change the controller config (#7042) resource_control: dynamically change the controller config (#7042) Dec 7, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 7, 2023
@nolouch
Copy link
Contributor

nolouch commented Dec 7, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 06d80ef

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 02b5952 into tikv:release-7.1 Dec 7, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants