Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use the PD leader member in server if it's not in etcd members (#7753)" #7755

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jan 25, 2024

What problem does this PR solve?

Issue Number: ref #7752.

What is changed and how does it work?

This reverts commit d3b93074bc0b33c9899e3322b82b77538c57ed67 from #7753.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Jan 25, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from disksing and nolouch January 25, 2024 03:13
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 25, 2024
…in etcd members (tikv#7753)"

This reverts commit d3b9307.

Signed-off-by: JmPotato <[email protected]>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2024
@JmPotato
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 25, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 25, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 055f45f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Merging #7755 (055f45f) into master (d3b9307) will decrease coverage by 0.15%.
The diff coverage is 85.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7755      +/-   ##
==========================================
- Coverage   70.26%   70.11%   -0.15%     
==========================================
  Files         430      430              
  Lines       47645    47641       -4     
==========================================
- Hits        33476    33402      -74     
- Misses      11410    11501      +91     
+ Partials     2759     2738      -21     
Flag Coverage Δ
unittests 70.11% <85.71%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit 9a82b47 into tikv:master Jan 25, 2024
25 of 26 checks passed
@JmPotato JmPotato deleted the revert_7753 branch January 25, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants