Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dr-autosync: add metrics (#7110) #7785

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7110

What problem does this PR solve?

Issue Number: Close #6975

What is changed and how does it work?

add some dr-autosync related metrics

image

numbers are used to distinguish different states, the map is

1: sync
2: async_wait
3: async
4: sync_recover

Check List

Tests

  • Manual test (add detailed scripts or steps below)

sync state

# HELP pd_replication_dr_recover_progress Progress of sync_recover process
# TYPE pd_replication_dr_recover_progress gauge
pd_replication_dr_recover_progress 0
# HELP pd_replication_dr_recovered_region Number of recovered regions
# TYPE pd_replication_dr_recovered_region gauge
pd_replication_dr_recovered_region 0
# HELP pd_replication_dr_state State of DR
# TYPE pd_replication_dr_state gauge
pd_replication_dr_state 1
# HELP pd_replication_dr_state_id State ID of DR
# TYPE pd_replication_dr_state_id gauge
pd_replication_dr_state_id 10
# HELP pd_replication_dr_tick_total Counter of background state check count
# TYPE pd_replication_dr_tick_total counter
pd_replication_dr_tick_total 64

async wait

# HELP pd_replication_dr_recover_progress Progress of sync_recover process
# TYPE pd_replication_dr_recover_progress gauge
pd_replication_dr_recover_progress 0
# HELP pd_replication_dr_recovered_region Number of recovered regions
# TYPE pd_replication_dr_recovered_region gauge
pd_replication_dr_recovered_region 0
# HELP pd_replication_dr_state State of DR
# TYPE pd_replication_dr_state gauge
pd_replication_dr_state 2
# HELP pd_replication_dr_state_id State ID of DR
# TYPE pd_replication_dr_state_id gauge
pd_replication_dr_state_id 221
# HELP pd_replication_dr_tick_total Counter of background state check count
# TYPE pd_replication_dr_tick_total counter
pd_replication_dr_tick_total 311

async

# HELP pd_replication_dr_recover_progress Progress of sync_recover process
# TYPE pd_replication_dr_recover_progress gauge
pd_replication_dr_recover_progress 0
# HELP pd_replication_dr_recovered_region Number of recovered regions
# TYPE pd_replication_dr_recovered_region gauge
pd_replication_dr_recovered_region 0
# HELP pd_replication_dr_state State of DR
# TYPE pd_replication_dr_state gauge
pd_replication_dr_state 3
# HELP pd_replication_dr_state_id State ID of DR
# TYPE pd_replication_dr_state_id gauge
pd_replication_dr_state_id 222
# HELP pd_replication_dr_tick_total Counter of background state check count
# TYPE pd_replication_dr_tick_total counter
pd_replication_dr_tick_total 385

sync recover

# HELP pd_replication_dr_recover_progress Progress of sync_recover process
# TYPE pd_replication_dr_recover_progress gauge
pd_replication_dr_recover_progress 0.24528302252292633
# HELP pd_replication_dr_recovered_region Number of recovered regions
# TYPE pd_replication_dr_recovered_region gauge
pd_replication_dr_recovered_region 0
# HELP pd_replication_dr_state State of DR
# TYPE pd_replication_dr_state gauge
pd_replication_dr_state 4
# HELP pd_replication_dr_state_id State ID of DR
# TYPE pd_replication_dr_state_id gauge
pd_replication_dr_state_id 223
# HELP pd_replication_dr_tick_total Counter of background state check count
# TYPE pd_replication_dr_tick_total counter
pd_replication_dr_tick_total 393

sync

# HELP pd_replication_dr_recover_progress Progress of sync_recover process
# TYPE pd_replication_dr_recover_progress gauge
pd_replication_dr_recover_progress 1
# HELP pd_replication_dr_recovered_region Number of recovered regions
# TYPE pd_replication_dr_recovered_region gauge
pd_replication_dr_recovered_region 53
# HELP pd_replication_dr_state State of DR
# TYPE pd_replication_dr_state gauge
pd_replication_dr_state 1
# HELP pd_replication_dr_state_id State ID of DR
# TYPE pd_replication_dr_state_id gauge
pd_replication_dr_state_id 224
# HELP pd_replication_dr_tick_total Counter of background state check count
# TYPE pd_replication_dr_tick_total counter
pd_replication_dr_tick_total 614

Release note

None.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Feb 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 1, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

ti-chi-bot bot commented Feb 1, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx February 1, 2024 04:00
Copy link
Contributor

ti-chi-bot bot commented Feb 1, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci/build 3c6532b link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@TonsnakeLin
Copy link
Contributor

Could you please resolve the cp conflict? @disksing

Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but need to fix conflict

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2024
@JmPotato JmPotato closed this Apr 17, 2024
@JmPotato JmPotato deleted the cherry-pick-7110-to-release-7.1 branch April 17, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants