Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

member: reset campaign times after successful resign #7795

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Feb 2, 2024

What problem does this PR solve?

Issue Number: Ref #7499

What is changed and how does it work?

member: reset campaign times after successful resign

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: husharp <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 2, 2024
@HuSharp HuSharp requested a review from JmPotato February 2, 2024 07:31
@ti-chi-bot ti-chi-bot bot requested a review from disksing February 2, 2024 07:31
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2024
@HuSharp HuSharp requested review from lhy1024 and removed request for disksing February 2, 2024 07:32
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Merging #7795 (b0ce2c1) into master (cd0ffba) will decrease coverage by 0.18%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7795      +/-   ##
==========================================
- Coverage   73.69%   73.51%   -0.18%     
==========================================
  Files         432      432              
  Lines       47805    47793      -12     
==========================================
- Hits        35229    35135      -94     
- Misses       9572     9629      +57     
- Partials     3004     3029      +25     
Flag Coverage Δ
unittests 73.51% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

HuSharp added a commit to HuSharp/pd that referenced this pull request Feb 2, 2024
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2024
@HuSharp HuSharp added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 2, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Feb 2, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

This pull request has been accepted and is ready to merge.

Commit hash: b0ce2c1

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 54ffd34 into tikv:master Feb 2, 2024
26 of 27 checks passed
@HuSharp HuSharp deleted the change_reset_order branch February 2, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants