Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): update TiDB Dashboard to v7.5.1-43fe8dac [release-7.5] #7825

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Feb 19, 2024

What problem does this PR solve?

Issue Number: ref #4257 #7561

Update TiDB Dashboard to v7.5.1-43fe8dac.

Release note

None

image

baurine and others added 3 commits February 19, 2024 14:31
close tikv#7612

Signed-off-by: baurine <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
…v#7563)

close tikv#7561

Pass TLS info to dashboard to fix TiKV heap profiling

Signed-off-by: Connor1996 <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Feb 19, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Feb 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 19, 2024

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2024
@baurine baurine force-pushed the chore/update-tidb-dashboard-7.5 branch from ee8b6c4 to 69df074 Compare February 19, 2024 07:39
@baurine baurine changed the title Chore/update tidb dashboard 7.5 chore(dashboard): update TiDB Dashboard to v7.5.1-43fe8dac [release-7.5] Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #7825 (69df074) into release-7.5 (3488a65) will increase coverage by 0.01%.
The diff coverage is 68.75%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #7825      +/-   ##
===============================================
+ Coverage        74.53%   74.54%   +0.01%     
===============================================
  Files              444      444              
  Lines            48140    48148       +8     
===============================================
+ Hits             35882    35893      +11     
+ Misses            9073     9068       -5     
- Partials          3185     3187       +2     
Flag Coverage Δ
unittests 74.54% <68.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 20, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 20, 2024
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 20, 2024
@nolouch
Copy link
Contributor

nolouch commented Feb 20, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 20, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 20, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 69df074

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 20, 2024
@nolouch
Copy link
Contributor

nolouch commented Feb 20, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Feb 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7294ff9 into tikv:release-7.5 Feb 20, 2024
21 of 24 checks passed
@baurine baurine deleted the chore/update-tidb-dashboard-7.5 branch February 22, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants