-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctl: replace config with HTTP SDK #7834
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
96303f2
to
7cb26ce
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7834 +/- ##
==========================================
+ Coverage 77.59% 77.66% +0.07%
==========================================
Files 474 474
Lines 61883 62008 +125
==========================================
+ Hits 48019 48160 +141
+ Misses 10334 10308 -26
- Partials 3530 3540 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
if err != nil { | ||
cmd.Printf("Failed to get cluster version: %s\n", err) | ||
return | ||
} | ||
cmd.Println(r) | ||
cmd.Println(`"` + r + `"`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keep the original one?
Signed-off-by: husharp <[email protected]>
999401e
to
f15bd60
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@HuSharp: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: Ref #7300
What is changed and how does it work?
Check List
Tests
Release note