Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdutil: only output the log when picked count > 0 #7845

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: close #7844.

What is changed and how does it work?

Only output the log when picked count > 0 in `updateEvictedEps`.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 22, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 22, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Merging #7845 (343337c) into master (d6d9fea) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7845      +/-   ##
==========================================
- Coverage   73.51%   73.44%   -0.08%     
==========================================
  Files         432      432              
  Lines       47913    47915       +2     
==========================================
- Hits        35225    35189      -36     
- Misses       9642     9671      +29     
- Partials     3046     3055       +9     
Flag Coverage Δ
unittests 73.44% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2024
@JmPotato
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 23, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 23, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 343337c

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2024
@ti-chi-bot ti-chi-bot bot merged commit cd85c24 into tikv:master Feb 23, 2024
26 of 27 checks passed
@JmPotato JmPotato deleted the fix_reset_evicted_ep_log branch February 23, 2024 03:35
@JmPotato JmPotato added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Mar 25, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #7977.

ti-chi-bot bot pushed a commit that referenced this pull request Mar 25, 2024
close #7844

Only output the log when picked count > 0 in `updateEvictedEps`.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many unnecessary reset evicted etcd endpoint logs
3 participants