Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: add hot write tests #7851

Merged
merged 2 commits into from
Feb 26, 2024
Merged

pkg: add hot write tests #7851

merged 2 commits into from
Feb 26, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 26, 2024

What problem does this PR solve?

Issue Number: Ref #7848.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 26, 2024
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Merging #7851 (89727c1) into master (6822137) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 89727c1 differs from pull request most recent head c83a3f8. Consider uploading reports for the commit c83a3f8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7851      +/-   ##
==========================================
- Coverage   73.54%   73.47%   -0.08%     
==========================================
  Files         432      432              
  Lines       47915    47915              
==========================================
- Hits        35241    35204      -37     
- Misses       9636     9663      +27     
- Partials     3038     3048      +10     
Flag Coverage Δ
unittests 73.47% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx removed the request for review from HunDunDM February 26, 2024 04:07
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 26, 2024
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 26, 2024
@rleungx
Copy link
Member Author

rleungx commented Feb 26, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 89727c1

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit d21c626 into tikv:master Feb 26, 2024
22 checks passed
@rleungx rleungx deleted the add-hot-write-test branch February 26, 2024 06:55
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Mar 31, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8004.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Mar 31, 2024
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Apr 1, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8054.

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 7, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8143.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants