Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade etcd to v3.4.30 #7884

Merged
merged 1 commit into from
Mar 7, 2024
Merged

*: upgrade etcd to v3.4.30 #7884

merged 1 commit into from
Mar 7, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Mar 6, 2024

What problem does this PR solve?

Issue Number: close #7904, ref #5520.

What is changed and how does it work?

Upgrade etcd to v3.4.30 and adopt the latest code changes.

Check List

Tests

  • Unit test
  • Integration test

Release note

Upgrade etcd to v3.4.30 to adopt the security patch.

Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 6, 2024
@ti-chi-bot ti-chi-bot bot requested review from disksing and rleungx March 6, 2024 07:53
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 6, 2024
@JmPotato JmPotato requested review from HuSharp and removed request for disksing March 6, 2024 07:54
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Merging #7884 (635d4ac) into master (32bba44) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7884      +/-   ##
==========================================
- Coverage   73.49%   73.42%   -0.07%     
==========================================
  Files         434      434              
  Lines       48035    48035              
==========================================
- Hits        35302    35272      -30     
- Misses       9690     9705      +15     
- Partials     3043     3058      +15     
Flag Coverage Δ
unittests 73.42% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 6, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Mar 6, 2024

/hold

It needs to be upgrade to "v3.4.30".

@JmPotato

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Mar 6, 2024

/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@wuhuizuo: once the present PR merges, I will cherry-pick it on top of release-6.1/release-6.5/release-7.1/release-7.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Mar 6, 2024

/cherry-pick release-7.5 /cherry-pick release-7.1 /cherry-pick release-6.5 /cherry-pick release-6.1

cc @JmPotato

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2024
@JmPotato JmPotato changed the title *: upgrade etcd to v3.4.26 *: upgrade etcd to v3.4.30 Mar 7, 2024
@JmPotato
Copy link
Member Author

JmPotato commented Mar 7, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@JmPotato
Copy link
Member Author

JmPotato commented Mar 7, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 9c0ae62

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2024
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2024
Signed-off-by: JmPotato <[email protected]>
@JmPotato
Copy link
Member Author

JmPotato commented Mar 7, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 635d4ac

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit 57cd603 into tikv:master Mar 7, 2024
25 of 26 checks passed
@JmPotato JmPotato deleted the update_etcd branch March 7, 2024 03:47
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.5: #7886.

In response to this:

/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Mar 7, 2024
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Mar 7, 2024
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.1: #7887.

In response to this:

/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-7.5: #7888.

In response to this:

/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Mar 7, 2024
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Mar 7, 2024
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-7.1: #7889.

In response to this:

/cherry-pick release-7.5
/cherry-pick release-7.1
/cherry-pick release-6.5
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Mar 12, 2024
ref #5520, close #7904

Upgrade etcd to v3.4.30 and adopt the latest code changes.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Mar 12, 2024
ref #5520, close #7904

Upgrade etcd to v3.4.30 and adopt the latest code changes.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
ti-chi-bot bot added a commit that referenced this pull request Mar 25, 2024
ref #5520, close #7904

Upgrade etcd to v3.4.30 and adopt the latest code changes.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade etcd to v3.4.30 to fix security vulnerabilities
5 participants