client: support specifying target member #7909
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/M
rleungx
force-pushed
the
follower-handle
branch
2 times, most recently
from
f25c245
to
0a084b3
Compare
rleungx
requested review from
CabinfeverB and
HuSharp
and removed request for
HunDunDM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7909 +/- ##
=======================================
Coverage 73.65% 73.66%
=======================================
Files 436 436
Lines 48503 48516 +13
=======================================
+ Hits 35727 35737 +10
+ Misses 9735 9727 -8
- Partials 3041 3052 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
client/http/client_test.go
Outdated
| c := newClientWithMockServiceDiscovery("test-with-target-url", []string{"http://127.0.0.1:2379", "http://127.0.0.2:2379", "http://127.0.0.3:2379"}) | ||
| defer c.Close() | ||
|
|
||
| _, err := c.WithTargetURL("http://127.0.0.4:2379").GetStatus(ctx) |
There was a problem hiding this comment.
Can we check the right follower target as well?
| @@ -111,6 +111,8 @@ type Client interface { | |||
| WithRespHandler(func(resp *http.Response, res any) error) Client | |||
| // WithBackoffer sets and returns a new client with the given backoffer. | |||
| WithBackoffer(*retry.Backoffer) Client | |||
| // WithTargetURL sets and returns a new client with the given target URL. | |||
| WithTargetURL(string) Client | |||
There was a problem hiding this comment.
Is it possible to make it a request-level option rather than a client one?
There was a problem hiding this comment.
We don't have the request level option now.
client/mock_pd_service_discovery.go
Outdated
| @@ -56,6 +56,7 @@ func (m *mockPDServiceDiscovery) GetAllServiceClients() []ServiceClient { | |||
| return m.clients | |||
| } | |||
|
|
|||
| func (m *mockPDServiceDiscovery) GetURL() string { return "" } | |||
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
follower-handle
branch
from
33f09b2
to
a16233c
Compare
rleungx
requested review from
JmPotato,
CabinfeverB and
HuSharp
and removed request for
CabinfeverB
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: a16233c
|
ti-chi-bot
bot
added
the
status/can-merge
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Ref #7905
What is changed and how does it work?
Check List
Tests
Release note