Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: fix cgroup monitor #7918

Merged
merged 2 commits into from
Mar 15, 2024
Merged

pkg: fix cgroup monitor #7918

merged 2 commits into from
Mar 15, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Mar 14, 2024

What problem does this PR solve?

Issue Number: Ref #7716.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Mar 14, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Mar 14, 2024
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and JmPotato March 14, 2024 07:57
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 14, 2024

@hawkingrei: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: Ryan Leung <[email protected]>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Merging #7918 (4dec7d0) into master (b9ea01a) will decrease coverage by 0.04%.
The diff coverage is 56.00%.

❗ Current head 4dec7d0 differs from pull request most recent head d9b469c. Consider uploading reports for the commit d9b469c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7918      +/-   ##
==========================================
- Coverage   73.56%   73.52%   -0.04%     
==========================================
  Files         436      436              
  Lines       48342    48351       +9     
==========================================
- Hits        35561    35552       -9     
- Misses       9726     9749      +23     
+ Partials     3055     3050       -5     
Flag Coverage Δ
unittests 73.52% <56.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2024
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 15, 2024
@rleungx
Copy link
Member Author

rleungx commented Mar 15, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 15, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 15, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 4dec7d0

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 15, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 6ee25f9 into tikv:master Mar 15, 2024
22 checks passed
@rleungx rleungx deleted the fix-cgroup-monitor branch March 15, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants